iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

change public key to JsonWebKey

Open ququzone opened this issue 2 years ago • 4 comments

Description

change public key to JsonWebKey

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

ququzone avatar Apr 22 '23 13:04 ququzone

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 22 '23 13:04 sonarqubecloud[bot]

Starting review process for this pull request send by **Xueping Yang**
**Commits** in this pull request: 1

**Additions**: 40
**Changed** files: 1
**Deletions**: 18

github-actions[bot] avatar Apr 22 '23 13:04 github-actions[bot]

🚨 Fail code review process for file ioctl/cmd/did/diddoc.go.

This model's maximum context length is 4097 tokens. However, you requested 4807 tokens (1735 in the messages, 3072 in the completion). Please reduce the length of the messages or completion.

github-actions[bot] avatar Apr 22 '23 13:04 github-actions[bot]

Codecov Report

Merging #3849 (9059890) into master (e1f0636) will increase coverage by 0.06%. The diff coverage is 71.09%.

:exclamation: Current head 9059890 differs from pull request most recent head 0d6c338. Consider uploading reports for the commit 0d6c338 to get more accurate results

@@            Coverage Diff             @@
##           master    #3849      +/-   ##
==========================================
+ Coverage   75.38%   75.44%   +0.06%     
==========================================
  Files         303      303              
  Lines       25923    26038     +115     
==========================================
+ Hits        19541    19645     +104     
- Misses       5360     5371      +11     
  Partials     1022     1022              
Impacted Files Coverage Δ
api/web3server_marshal.go 93.21% <ø> (ø)
api/web3server_utils.go 69.20% <16.66%> (-3.67%) :arrow_down:
state/factory/factory.go 80.20% <33.33%> (+0.86%) :arrow_up:
state/factory/statedb.go 81.81% <33.33%> (+1.08%) :arrow_up:
api/serverV2.go 86.95% <50.00%> (ø)
state/factory/workingset.go 71.42% <68.75%> (ø)
api/web3server.go 81.41% <87.50%> (+2.74%) :arrow_up:
api/coreservice.go 68.09% <88.23%> (+0.74%) :arrow_up:
action/protocol/context.go 67.42% <100.00%> (+0.24%) :arrow_up:
blockchain/genesis/genesis.go 72.36% <100.00%> (ø)

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Apr 22 '23 14:04 codecov[bot]

Close b/c it has been inactive for 1+yr.

raullenchai avatar May 30 '24 20:05 raullenchai