iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

[genesis] Remove init() in genesis.go

Open Liuhaai opened this issue 2 years ago • 2 comments

Description

  1. Rename genesis.Default to genesis.DefaultConfig
  2. Replace genesis.Default in the tessts with genesis.TestConfig()

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Liuhaai avatar Jan 20 '23 05:01 Liuhaai

Codecov Report

Merging #3783 (b48ced0) into master (263ff82) will increase coverage by 0.93%. The diff coverage is 80.17%.

:exclamation: Current head b48ced0 differs from pull request most recent head 02e0e5a. Consider uploading reports for the commit 02e0e5a to get more accurate results

@@            Coverage Diff             @@
##           master    #3783      +/-   ##
==========================================
+ Coverage   74.47%   75.41%   +0.93%     
==========================================
  Files         269      300      +31     
  Lines       23925    25417    +1492     
==========================================
+ Hits        17818    19168    +1350     
- Misses       5174     5267      +93     
- Partials      933      982      +49     
Impacted Files Coverage Δ
action/actctx.go 90.62% <ø> (+6.25%) :arrow_up:
action/action.go 82.35% <ø> (ø)
action/action_deserializer.go 57.14% <ø> (ø)
action/candidate_update.go 88.88% <0.00%> (-4.14%) :arrow_down:
action/consignment_transfer.go 90.41% <ø> (ø)
action/const.go 100.00% <ø> (ø)
action/execution.go 83.78% <ø> (ø)
action/grantreward.go 68.57% <ø> (ø)
action/protocol/account/protocol.go 86.90% <ø> (ø)
action/protocol/dock.go 100.00% <ø> (ø)
... and 280 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jan 20 '23 19:01 codecov[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.0% 10.0% Duplication

sonarqubecloud[bot] avatar Jan 28 '23 01:01 sonarqubecloud[bot]

Close b/c it has been inactive for 1+yr.

raullenchai avatar May 30 '24 20:05 raullenchai