iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

[pkg] panic if no space is left

Open huof6829 opened this issue 3 years ago • 4 comments

Description

Fixes https://github.com/iotexproject/iotex-core/issues/3629

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

huof6829 avatar Sep 13 '22 10:09 huof6829

Codecov Report

Merging #3636 (b6bbdd2) into master (e9732a1) will decrease coverage by 0.28%. The diff coverage is 80.72%.

@@            Coverage Diff             @@
##           master    #3636      +/-   ##
==========================================
- Coverage   74.95%   74.67%   -0.29%     
==========================================
  Files         269      267       -2     
  Lines       23819    23784      -35     
==========================================
- Hits        17854    17761      -93     
- Misses       5039     5090      +51     
- Partials      926      933       +7     
Impacted Files Coverage Δ
db/config.go 100.00% <ø> (ø)
db/trie/mptrie/node.go 100.00% <ø> (ø)
ioctl/newcmd/action/action.go 79.62% <ø> (+0.09%) :arrow_up:
ioctl/newcmd/node/nodedelegate.go 70.19% <0.00%> (-0.95%) :arrow_down:
ioctl/newcmd/node/nodeprobationlist.go 90.90% <0.00%> (-4.33%) :arrow_down:
server/itx/server.go 60.00% <25.00%> (-2.21%) :arrow_down:
action/protocol/execution/evm/evm.go 44.57% <26.66%> (-0.86%) :arrow_down:
db/trie/mptrie/hashnode.go 36.36% <41.17%> (-54.55%) :arrow_down:
db/trie/mptrie/merklepatriciatrie.go 78.73% <46.80%> (-12.70%) :arrow_down:
db/db_bolt.go 72.13% <50.00%> (-0.39%) :arrow_down:
... and 23 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 13 '22 10:09 codecov[bot]

I think we don't need to monitor disk, just need to PANIC when write DB error is disk full

millken avatar Sep 14 '22 06:09 millken

add log rotate and delete expired logs can be better.

huof6829 avatar Sep 14 '22 12:09 huof6829

@huof6829 @millken has the problem been resolved?

CoderZhi avatar Oct 11 '22 18:10 CoderZhi

fixed. I have no problem.

huof6829 avatar Oct 12 '22 02:10 huof6829

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 12 '22 09:10 sonarqubecloud[bot]