iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

[ioctl] Build stake2 withdraw command line into new ioctl

Open LuckyPigeon opened this issue 3 years ago • 1 comments

Description

Build stake2withdraw command in new ioctl, with the following note.

  • Use client interface to construct the Cobra command.
  • Output package is deprecated, replace it with errors package.
  • Replace fmt.Println with cmd.Println
  • Refactor unit test to cover the modification.

Fixes #3333

Type of change

Please delete options that are not relevant.

  • [x] Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] make test
  • [x] TestNewStake2WithdrawCmd

Test Configuration:

  • Firmware version: Ubuntu 21.04
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules****

LuckyPigeon avatar Aug 03 '22 21:08 LuckyPigeon

Codecov Report

Merging #3582 (506d4d8) into master (a20e489) will decrease coverage by 1.13%. The diff coverage is 69.90%.

@@            Coverage Diff             @@
##           master    #3582      +/-   ##
==========================================
- Coverage   75.43%   74.29%   -1.14%     
==========================================
  Files         247      259      +12     
  Lines       22845    23532     +687     
==========================================
+ Hits        17233    17483     +250     
- Misses       4685     5123     +438     
+ Partials      927      926       -1     
Impacted Files Coverage Δ
action/action_deserializer.go 57.14% <ø> (ø)
action/protocol/poll/nativestaking.go 41.08% <0.00%> (-0.65%) :arrow_down:
action/protocol/poll/staking_command.go 10.71% <0.00%> (ø)
action/protocol/staking/read_state.go 15.38% <0.00%> (ø)
action/protocol/vote/probationlist.go 87.50% <ø> (ø)
api/blocklistener.go 70.73% <0.00%> (ø)
api/websocket.go 5.17% <0.00%> (-0.19%) :arrow_down:
blockchain/block/block_deserializer.go 71.15% <ø> (ø)
blockchain/blockchain.go 0.89% <0.00%> (ø)
blockchain/filedao/filedao_legacy.go 85.80% <ø> (ø)
... and 104 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 03 '22 21:08 codecov[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
3.7% 3.7% Duplication

sonarqubecloud[bot] avatar Aug 23 '22 03:08 sonarqubecloud[bot]