Fabio Zanini
Fabio Zanini
Good to finally have a written discussion about this since it's been bothering me forever. I agree with all that was said. In practice, this is tightly coupled to the...
I'm more optimistic about the graph representation than @szhorvat Nobody is leaving this to the last minute. But working on it before we have a plan re representation is not...
TBH, that sounds reasonable @szhorvat, +1 from me
We could make an optional input argument called `compute_Pvalue=True` that skips the last part and is used just to compute the max distance and its location. Would that be a...
No problem, I'll get it done as soon as I get back to Oz (haven't slept in a while now...) Thank you!
Thanks @mdhaber - I was just overwhelmed in the last few days. I have now added decent test functions, improved docstrings a little, and changed a piece of logic that...
Hey @mdhaber - thank you again for your PR. I merged it and added similar tests for the one-sample KS test. I think this is ready to go in if...
Sorry Matt, was taken in by some stuff! Let me check test results properly and I'll ask for review at that point. A day or two. Thank you On Sun,...
Thanks @mdhaber - implemented all requested changes. No further edits necessary AFAICT.
@mdhaber Thanks for the comment. I disagree that symmetry is essential. The 1-sample KS test is against a continuous distribution, whereas the 2-sample test is against a discretization thereof, which...