stencil-sass
stencil-sass copied to clipboard
Make `sass` a peerDependency
Instead of manually updating the sass dependency every time an update is available, it could be done by the consumer instead.
This would be really helpful for us as well 👍
+100
Hey folks,
Thanks for the patience on this one. After doing a little digging and discussing with the team, we've come to consensus that making sass a peer dependency is not something we feel is the right decision for this library.
This decision is influenced by the following points:
- We believe that making
sassa peer dependency will increase the difficulty in maintaining this library. The points below can lead to incompatibilities between this library andsass(increasing maintenance burden):sasscan have breaking changes in minor versions, often called "maybe breaking changes" (reference)- The Sass 1.55 upgrade breaks the development cycle of
@stencil/sass, as typings provided bySasschange in ways that cause build failures
- We control the version of
sassused today, which simplifies our support matrix of this library andsass - While we could make
sassa peer-dependency, we believe we would need to make that peer-dependency rather restrictive, which we believe creates a compromise where nobody is quite pleased with the outcome.
I'm going to be scheduling https://github.com/ionic-team/stencil-sass/pull/157 to be completed in the near future, so that we can support a newer version of Sass.
Thanks!