ionic-framework icon indicating copy to clipboard operation
ionic-framework copied to clipboard

refactor(card): add common file and ionic test

Open thetaPC opened this issue 1 year ago • 2 comments
trafficstars

Issue number: N/A


What is the current behavior?

The file style structure for card does not follow the new structure containing the common styles.

What is the new behavior?

  • Split the files into common and native for styles.
  • Added the ionic theme to the basic test.
  • Forced the ionic test page to always be set to ionic.

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

Preview

thetaPC avatar Jul 19 '24 22:07 thetaPC

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 6:29pm

vercel[bot] avatar Jul 19 '24 22:07 vercel[bot]

I think this will have conflicts with https://github.com/ionic-team/ionic-framework/pull/29757 which I was going to merge soon

brandyscarney avatar Aug 09 '24 19:08 brandyscarney

Closing since this has been done through another PR.

thetaPC avatar Aug 29 '24 19:08 thetaPC