ionic-framework
ionic-framework copied to clipboard
chore(deps): update mcr.microsoft.com/playwright docker tag to v1.44.0
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| mcr.microsoft.com/playwright | final | minor | v1.43.1 -> v1.44.0 |
Configuration
📅 Schedule: Branch creation - "every weekday before 11am" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, check this box
This PR has been generated by Mend Renovate. View repository job log here.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| ionic-framework | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 17, 2024 8:36pm |
@thetaPC I wouldn't merge this as-is. The playwright version for the docker image should match the project dependency and renovate should be grouping those dependency updates: https://github.com/ionic-team/ionic-framework/blob/88db93819fc440c1ca85c980026cc758166d05d8/renovate.json5#L24-L40
I would have expected a bump to the lock file for the core package to @playwright/test.
This might have something to do with the age of the dependency. I ran into the same problem on a personal repo. Your renovatebot config requires a minimum release age of 3 days. This version of Playwright only came out yesterday, so the npm dependency has not met the min 3 day requirement.
I would have expected the same to be true for the Docker dependency, but maybe minimumReleaseAge works differently/is not supported with Docker deps?
I need to dig a bit deeper into this. Yesterday I was able to verify through the Renovate logs that it sees that Playwright needs to be updated. But it never commits to it. So the 3 day minimum mentioned by @liamdebeasi might not be related.
Based on my investigation, the renovate config needs to be modified. The current setup is allowing any package within the group to upgrade regardless if not all of them are ready. This GH discussions provides an example of how we should go about it. I'll open a separate PR to test it further.
In the meantime, Playwright finally updated after the 3 days minimum as mentioned so we can proceed.
The hold up is that some tests are failing. I was able to identify one of the issues is due to Playwright upgrading Chrome, which now has datetime acting differently when font size is scaling. This is actually good because now it behaves like the other browsers.
Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠️ Warning: custom changes will be lost.