ionic-framework icon indicating copy to clipboard operation
ionic-framework copied to clipboard

Published 20 hours ago • verified publisher icon ionic-team

refactor: exportable md animations for modal

Open reslear opened this issue 2 years ago • 3 comments
trafficstars

It is convenient from the point of view when ios style need md style animation (https://ionicframework.com/docs/api/modal#enteranimation) that would not copy the code in the application and always use the latest changes.

exportable mdEnterModalAnimation and mdLeaveModalAnimation

closes: #28499

reslear avatar Nov 03 '23 16:11 reslear

Hey there, could you please create an issue for this? We'd like to understand the use case for this feature before we expose this API. Thanks!

liamdebeasi avatar Nov 06 '23 22:11 liamdebeasi

Hey there, could you please create an issue for this? We'd like to understand the use case for this feature before we expose this API. Thanks!

I think there is already an open issue which address this PR: #24964 (#25243). It would be great if we could extend this PR to also export ios enter/leave animation as well.

DwieDima avatar Nov 09 '23 11:11 DwieDima

@liamdebeasi @DwieDima I suggested a more interesting solution in the form of presets see 2 https://github.com/ionic-team/ionic-framework/issues/28499

reslear avatar Nov 09 '23 13:11 reslear