ionic-framework icon indicating copy to clipboard operation
ionic-framework copied to clipboard

refactor(ga-screenshots): option to test single component

Open thetaPC opened this issue 2 years ago • 4 comments
trafficstars

Issue number: N/A


What is the current behavior?

All the E2E tests are run when performing the "Update Reference Screenshots" GitHub actions.

What is the new behavior?

  • All E2E tests still run as default.
  • The GH action has the option to run a specific component instead of all tests.
    • A specified component has the option to run all tests that include the component's name in the file path
    • A specified component has the option to run all tests that are in the component's folder
  • If a single component is selected, then the default is to only run tests inside it's folder.

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

Recommended to test:

  • a component with the ion prefix (ion-button)
  • a component without the prefix (button)
  • a component that doesn't exist (random-component)
  • no provided component, leave the first input blank
  • the checkbox

thetaPC avatar Jul 21 '23 15:07 thetaPC

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

I think this might need a little more testing and exploration. Here's an example run I did on a fork of this branch: https://github.com/ionic-team/ionic-framework/actions/runs/5943476177/job/16118770162

I modified two components (button and radio) and ran this job against the branch, filtering on button.

Let me know if you have any questions!

sean-perkins avatar Aug 22 '23 20:08 sean-perkins

I think this might need a little more testing and exploration. Here's an example run I did on a fork of this branch: https://github.com/ionic-team/ionic-framework/actions/runs/5943476177/job/16118770162

I modified two components (button and radio) and ran this job against the branch, filtering on button.

Let me know if you have any questions!

Got it! I'll look into this more. Thank you!

thetaPC avatar Aug 22 '23 21:08 thetaPC

I'm going to remove myself from review. Feel free to re-add me once it is ready for another look!

sean-perkins avatar Aug 31 '23 16:08 sean-perkins