ionic-cli icon indicating copy to clipboard operation
ionic-cli copied to clipboard

@ionic/cli: Fixed 404 error for lab-logo.png

Open charliejlevine opened this issue 3 years ago • 0 comments

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @ionic/[email protected] for the project I'm working on.

Description: Fixed 404 error for lab-logo.png

Here is the diff that solved my problem:

diff --git a/node_modules/@ionic/lab/www/assets/app.css b/node_modules/@ionic/lab/www/assets/app.css
index 620a151..4774166 100644
--- a/node_modules/@ionic/lab/www/assets/app.css
+++ b/node_modules/@ionic/lab/www/assets/app.css
@@ -52,7 +52,7 @@ header .icon {
 #logo {
   display: inline-block;
   vertical-align: middle;
-  background: url('lab-logo.png');
+  background: url('assets/lab-logo.png');
   background-size: 100%;
   background-repeat: no-repeat;
   margin-top: -2px;
diff --git a/node_modules/@ionic/lab/www/index.html b/node_modules/@ionic/lab/www/index.html
index 2be9e0a..4a6bec4 100644
--- a/node_modules/@ionic/lab/www/index.html
+++ b/node_modules/@ionic/lab/www/index.html
@@ -92,7 +92,7 @@ header .icon {
 #logo {
   display: inline-block;
   vertical-align: middle;
-  background: url('lab-logo.png');
+  background: url('assets/lab-logo.png');
   background-size: 100%;
   background-repeat: no-repeat;
   margin-top: -2px;

This issue body was partially generated by patch-package.

charliejlevine avatar Apr 18 '22 08:04 charliejlevine