Extra iOS and Android configuration fields to add Capacitor to existing native apps

[Kniniurb]

trafficstars

Some minor changes to config.ts and ios/update.ts to introduce more flexibility in how the iOS and Android projects are named and organised. Purpose: To add Capacitor to existing native projects.

[Squixx]

Anyone willing to review this?

[Kniniurb]

Hi Martin,

Thank you for the approval. How can I merge this with the main branch as I do not have write access and how can I perform the 6 checks listed below?

Best regards,

Peter Bruinink

Op vr 4 mrt. 2022 om 12:45 schreef Martin DONADIEU @.***

:

@.**** approved this pull request.

— Reply to this email directly, view it on GitHub https://github.com/ionic-team/capacitor/pull/5343#pullrequestreview-900129045, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEJMMIY2DRNF6TG7T4UNBLU6HZU3ANCNFSM5LBMAJJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

[riderx]

You can't, it's still necessary for a team member to review it :/

[Kniniurb]

Thanks!! Any idea how to get a team member to review it?

Op za 5 mrt. 2022 om 05:45 schreef Martin DONADIEU @.***

:

You can't, it's still necessary for a team member to review it :/

— Reply to this email directly, view it on GitHub https://github.com/ionic-team/capacitor/pull/5343#issuecomment-1059684562, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEJMMOZWPWB5FUHTCU5YPTU6LRHBANCNFSM5LBMAJJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

[giralte-ionic]

@Kniniurb this feature seems very similar to our Portals project - will this suit your needs or do you have a different use-case?

[Kniniurb]

Hi giralte-ionic,

This sounds surely interesting. I will have a look whether it indeed meets our request.

Regards, Peter

Op di 8 mrt. 2022 om 16:16 schreef giralte-ionic @.***>:

@Kniniurb https://github.com/Kniniurb this feature seems very similar to our Portals https://github.com/ionic-team/ionic-portals project - will this suit your needs or do you have a different use-case?

— Reply to this email directly, view it on GitHub https://github.com/ionic-team/capacitor/pull/5343#issuecomment-1061886859, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEJMMLGO3KFPDDM67ZKW2LU65VNFANCNFSM5LBMAJJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

[giralte-ionic]

Closing after a year of inactivity

[riderx]

@giralte-ionic portal is only available for Paid customers, the solution of @Kniniurb was good for open-source side

[giralte-ionic]

@riderx Portals is open-source. I linked to the GitHub repo above. Getting a key is free.

The purposes of these projects are distinct.

[riderx]

the onboarding requires to register to ionic, on the website it say it's paid and contact the sales team. In the doc it's say the token is free. Seems portal are not as Open as Capacitor, that why the PR is still valid for me.