capacitor icon indicating copy to clipboard operation
capacitor copied to clipboard

Published 20 hours ago • verified publisher icon ionic-team

Support CORS when using Live Reload

Open diachedelic opened this issue 5 years ago • 5 comments

A repeat of https://github.com/ionic-team/capacitor/pull/2882, with some improvements.

Even if this will be superseded by Capacitor v3, I would still like to see this merged for v2. I am using patch-package for now :(

diachedelic avatar Aug 19 '20 06:08 diachedelic

@diachedelic are you still running cap 2?

riderx avatar Mar 04 '22 11:03 riderx

@riderx Yes, why do you ask?

diachedelic avatar Mar 04 '22 22:03 diachedelic

Because it's 2 years old maybe it was outdated, and not necessary :)

riderx avatar Mar 05 '22 04:03 riderx

I think this fix is still relevant to Capacitor 3. The relevant file was renamed to WebViewAssetHandler.swift, but was not substantially changed. This patch still applies.

diachedelic avatar Mar 05 '22 05:03 diachedelic

@diachedelic i understand, but there are no really point to stay in capacitor 2. for me :/ The gap is not huge to migrate, and the benefice are huge.

riderx avatar Mar 05 '22 17:03 riderx

closing since capacitor 2 is not supported and a similar change is already present in newer versions

jcesarmobile avatar Jan 18 '24 13:01 jcesarmobile