[bug]: CFG Rescale Multiplier does not default to 0

[CubeTheThird]

Is there an existing issue for this problem?

• [x] I have searched the existing issues

Operating system

Linux

GPU vendor

AMD (ROCm)

GPU model

No response

GPU VRAM

No response

Version number

5.6.0

Browser

Firefox 134

Python dependencies

No response

What happened

When pressing the 'use model defaults' button, the CFG Rescale Multiplier setting remains unchanged.

What you expected to happen

The CFG Rescale Multiplier to reset to 0

How to reproduce the problem

• Pick a model that leaves the CFG Rescale Multiplier to default
• Select that model
• Change some settings, including CFG Rescale Multiplier
• Press the Use model defaults button
• Note the CFG Rescale Multiplier hasn't changed

Additional context

In general the model settings aren't changed if default is selected. This isn't necessarily a problem, but the CFG Rescale Multiplier is in a different section, and could easily be missed. The vast majority of models do not use it (i.e. set to 0), so it would be easy to miss it not being set correctly after it was changed.

Discord username

cubethethird

[CubeTheThird]

Still an issue in Invoke 5.7.2

[CubeTheThird]

Still an issue in Invoke 5.9.0

[hipsterusername]

This is a good first issue for anyone looking to contribute

[CubeTheThird]

Still an issue in Invoke 5.10.1

[CubeTheThird]

Still an issue in Invoke 5.11

[CubeTheThird]

Still an issue in Invoke 5.12

[CubeTheThird]

Still an issue in Invoke 5.14

[jeremygooch]

(Obligatory preamble, please forgive my naive-ness in this area, I'm green to the project)

I would like to fix this one, but I need some small clarifications.

I noticed that there seems to be a bug if the model has the CFG Rescale Multiplier default enabled (the toggle is blue), but the value is 0. When you then click the Restore Defaults icon it doesn't reset the value, and the Restore Defaults icon erroneously stays on.

However, I believe this issue considers the default disabled (the toggle is gray) and would like to reset it to 0 as if the default was 0, basically making the UI opinonated on this value.

Both should be simple to address in a PR but I want to make sure both are needed, or just one.

[CubeTheThird]

In my opinion, it should default to 0 when not specified. A lot of models (at least with SDXL ones I've used) produce odd results with it on, and so I would expect that in most cases it is detrimental to use unless explicitly set. Just my 2 cents though.

[jeremygooch]

Thanks @CubeTheThird. That's what I was assuming, but as I was exploring this area I noticed the other bug (due to a JS truthiness check that is equating 0 with false), so I wanted to make sure it wasn't instead that bug that needed to be updated. From what I see in the code both should be very simple to fix so I'll try to have a PR here soon.

[CubeTheThird]

Confirmed fixed in 6.0.0. Thanks!