InvokeAI icon indicating copy to clipboard operation
InvokeAI copied to clipboard

Improved working directory and import management

Open GithubUserAccountAmazing opened this issue 2 years ago • 2 comments

This pull request introduces the following improvements:

Added

  • ~Code to get the current working directory.~
  • ~Code to get the expected working directory based on the location of invokeai_configure.py file.~
  • ~Logic to switch to the expected working directory if it differs from the current one and to exit gracefully if an error occurs.~

Changed

  • The Imports to follow PEP 8 style guide more closely.
  • The imports from the local invokeai package to use absolute paths.

Thank you for the contribution. Good call on replacing relative paths with package imports.

Could you please provide some context on what is being solved by the working directory change? What is the "expected" directory here?

The current expectation is that the config interface should work irrespective of the current working directory - is that breaking for you in some way?

Thank you!

ebr avatar Apr 24 '23 04:04 ebr

@RichKMLS - Can you share your thoughts on the above inquiries?

hipsterusername avatar May 10 '23 12:05 hipsterusername

This PR seems to be inactive. There is an outstanding question with regard to the purpose of this change. @RichKMLS can you respond?

lstein avatar Jun 26 '23 19:06 lstein

Closing this PR as inactive

Millu avatar Nov 02 '23 23:11 Millu