react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

Fix typos in app-check index.md

Open tj-mc opened this issue 5 months ago • 2 comments

The current JS examples cannot be copied into an editor. Most systems use double or single quotes for imports, not backticks. There was also a missing "const" in one of the examples

Description

Related issues

Release Summary

Improve code examples for App Check.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [x] Yes
  • My change supports the following platforms;
    • [x] Android
    • [x] iOS
    • [x] Other (macOS, web)
  • My change includes tests;
    • [ ] e2e tests added or updated in packages/\*\*/e2e
    • [ ] jest tests added or updated in packages/\*\*/__tests__
  • [ ] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [x] No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

tj-mc avatar Jun 16 '25 06:06 tj-mc

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 4:56pm

vercel[bot] avatar Jun 16 '25 06:06 vercel[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: mikehardy
:x: tj-mc
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 16 '25 06:06 CLAassistant

No worries :D Yes I plan to sort this out tomorrow. Thanks for your work on this important module.

tj-mc avatar Jun 30 '25 06:06 tj-mc

Should I fix the CI error above? CLA signed

tj-mc avatar Jun 30 '25 07:06 tj-mc

I pushed a commit with the fix for prettier - just some spacing and single-ticks vs double-ticks. Not backticks though :) That should also prompt CLA bot to recheck, I'm not sure - that is not working well on another PR also

mikehardy avatar Jun 30 '25 16:06 mikehardy