react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

feat(firebase-ai): create `ai` package, `vertexai` wraps around it

Open russellwheatley opened this issue 6 months ago • 1 comments

Description

  • Moved the bulk of code to new ai package. Kept relevant types in vertexai package and deprecated them.
  • Updated implementation (where possible) to match firebase-js-sdk.
  • Updated mocks to match latest implementation on vertexai-sdk-test-data repo which now segments responses from vertexai and googleai.
  • I did attempt to symlink ai into vertexai but nested symlinks within directories were not being packaged in dist/ so opted to make ai package a dependency which I think is a better way of doing it.
  • Created an ai example app for illustration and tested latest vertexai and ai implementations which surfaced a couple of subtle bugs that have been resolved.

Important

  • We need to do the same attribution as we did for vertexai for this pull request.
  • Double check what needs to be in the CHANGELOG for this release.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [ ] Yes
  • My change supports the following platforms;
    • [ ] Android
    • [ ] iOS
    • [ ] Other (macOS, web)
  • My change includes tests;
    • [ ] e2e tests added or updated in packages/\*\*/e2e
    • [ ] jest tests added or updated in packages/\*\*/__tests__
  • [ ] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [ ] No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

russellwheatley avatar Jun 03 '25 09:06 russellwheatley

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-native-firebase Ready Ready Preview Comment Aug 18, 2025 0:22am

vercel[bot] avatar Jun 03 '25 09:06 vercel[bot]

Looking into this one now for review - noticed Other tests were failing because TextEncoder implementation seems to be missing and is needed ? Unexpected as it seems that should have been failing for a while if so, but...okay

rebased to main and put an in situ implementation of the string -> uint8array conversion in the storage library and it passes locally, hopefully this goes green in CI - will finish the review later

mikehardy avatar Jul 22 '25 16:07 mikehardy