react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

fix(firestore): type definitions

Open SelaseKay opened this issue 9 months ago • 5 comments

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [ ] Yes
  • My change supports the following platforms;
    • [ ] Android
    • [ ] iOS
    • [ ] Other (macOS, web)
  • My change includes tests;
    • [ ] e2e tests added or updated in packages/\*\*/e2e
    • [ ] jest tests added or updated in packages/\*\*/__tests__
  • [ ] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [ ] No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

SelaseKay avatar Feb 28 '25 11:02 SelaseKay

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2025 0:50am

vercel[bot] avatar Feb 28 '25 11:02 vercel[bot]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Mar 28 '25 15:03 github-actions[bot]

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.79%. Comparing base (8f59579) to head (796493f). Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8378      +/-   ##
==========================================
- Coverage   71.78%   69.79%   -1.99%     
==========================================
  Files         163      187      +24     
  Lines        6626     8039    +1413     
  Branches     1524     1840     +316     
==========================================
+ Hits         4756     5610     +854     
- Misses       1749     2238     +489     
- Partials      121      191      +70     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 24 '25 00:04 codecov[bot]

Kept definition for onSnapshotsInSync() which will merge with other PR that actually implements it.

MichaelVerdon avatar Apr 29 '25 09:04 MichaelVerdon

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar May 27 '25 11:05 github-actions[bot]

@russellwheatley / @MichaelVerdon I rebased this to main and pushed it out, minus the empty modular/VectorValue.d.ts file - I think this is ready to go though ? +1 from me for merge anyway. Any last thoughts from you two no this one?

mikehardy avatar Jul 01 '25 00:07 mikehardy

I think this should be reverted as the updates to type definitions are incorrect. Query, CollectionReference and friends only take one type parameter. Firestore types are currently broken for all typescript-based consumers in #8611

macksal avatar Sep 11 '25 14:09 macksal

I believe this is already being fixed as per the comment above, but just in case, I'm also getting querySnapshot as any in all of my onSnapshot usage. This was not happening before, and I recently updated to 23.3.1.

This is the signature I'm using:

import { onSnapshot } from '@react-native-firebase/firestore';

const unsubscribe = onSnapshot(q, (querySnapshot <--- this is being evaluated as any) => {});

cbdeveloper avatar Sep 22 '25 10:09 cbdeveloper