react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

chore(analytics): deprecation warnings for v8 API ahead of future major release

Open russellwheatley opened this issue 11 months ago • 7 comments

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [ ] Yes
  • My change supports the following platforms;
    • [ ] Android
    • [ ] iOS
  • My change includes tests;
    • [ ] e2e tests added or updated in packages/\*\*/e2e
    • [ ] jest tests added or updated in packages/\*\*/__tests__
  • [ ] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [ ] No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

russellwheatley avatar Dec 20 '24 10:12 russellwheatley

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2025 11:23am

vercel[bot] avatar Dec 20 '24 10:12 vercel[bot]

@mikehardy - Started this and I wanted to get your thoughts on the modular event methods we've ported over.

The firebase-js-sdk doesn't have methods for every event, they just have logEvent() to be used for custom and reserved events: https://firebase.google.com/docs/reference/js/analytics

Wondering whether we should deprecate all the modular methods we've ported over and just use logEvent()?

examples: https://github.com/invertase/react-native-firebase/blob/main/packages/analytics/lib/modular/index.js#L165-L187

Part of me thinks they're useful but another part thinks we should stick to firebase-js-sdk API 🤔

russellwheatley avatar Dec 20 '24 11:12 russellwheatley

@russellwheatley Deviating from firebase-js-sdk API is a slippery slope and at least personally I can only justify it when there is a native method that's really useful and has no analog we can do with firebase-js-sdk - logEvent seems sufficient as an analog, to me. I don't think the specific methods meet the bar to justify deviation from firebase-js-sdk, so I'd deprecate them and go 100% JS API here

mikehardy avatar Dec 20 '24 14:12 mikehardy

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Jan 17 '25 14:01 github-actions[bot]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Mar 03 '25 23:03 github-actions[bot]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Apr 16 '25 13:04 github-actions[bot]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar May 26 '25 12:05 github-actions[bot]