react-native-firebase
react-native-firebase copied to clipboard
chore(analytics): deprecation warnings for v8 API ahead of future major release
Related issues
Release Summary
Checklist
- I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [ ] Yes
- My change supports the following platforms;
- [ ]
Android - [ ]
iOS
- [ ]
- My change includes tests;
- [ ]
e2etests added or updated inpackages/\*\*/e2e - [ ]
jesttests added or updated inpackages/\*\*/__tests__
- [ ]
- [ ] I have updated TypeScript types that are affected by my change.
- This is a breaking change;
- [ ] Yes
- [ ] No
Test Plan
Think react-native-firebase is great? Please consider supporting the project with any of the below:
- 👉 Star this repo on GitHub ⭐️
- 👉 Follow
React Native FirebaseandInvertaseon Twitter
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-native-firebase | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 2, 2025 11:23am |
@mikehardy - Started this and I wanted to get your thoughts on the modular event methods we've ported over.
The firebase-js-sdk doesn't have methods for every event, they just have logEvent() to be used for custom and reserved events: https://firebase.google.com/docs/reference/js/analytics
Wondering whether we should deprecate all the modular methods we've ported over and just use logEvent()?
examples: https://github.com/invertase/react-native-firebase/blob/main/packages/analytics/lib/modular/index.js#L165-L187
Part of me thinks they're useful but another part thinks we should stick to firebase-js-sdk API 🤔
@russellwheatley Deviating from firebase-js-sdk API is a slippery slope and at least personally I can only justify it when there is a native method that's really useful and has no analog we can do with firebase-js-sdk - logEvent seems sufficient as an analog, to me. I don't think the specific methods meet the bar to justify deviation from firebase-js-sdk, so I'd deprecate them and go 100% JS API here
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically
Hello 👋, this PR has been opened for more than 2 months with no activity on it.
If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!
You have 15 days until this gets closed automatically