react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

feat(analytics): allow custom event parameters for Item in events

Open Pietahr opened this issue 1 year ago • 7 comments
trafficstars

Description

We wanted to add custom parameters to the items for ecommerce events. Firebase supports it (https://developers.google.com/analytics/devguides/collection/ga4/item-scoped-ecommerce), but it was not yet supported by react-native-firebase. This MR is inspired by https://github.com/invertase/react-native-firebase/pull/5811

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [x] Yes
  • My change supports the following platforms;
    • [ ] Android
    • [ ] iOS
  • My change includes tests;
    • [ ] e2e tests added or updated in packages/\*\*/e2e
    • [x] jest tests added or updated in packages/\*\*/__tests__
  • [ ] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [x] No

Test Plan

I added a test case.


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Pietahr avatar Jul 15 '24 15:07 Pietahr

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 5:02pm

vercel[bot] avatar Jul 15 '24 15:07 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 15 '24 15:07 CLAassistant

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Aug 13 '24 13:08 github-actions[bot]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Sep 30 '24 14:09 github-actions[bot]

This is something I'm looking to use as well. Is there anything I can do to help this across the line?

dannyBies avatar Oct 02 '24 16:10 dannyBies

Hey @dannyBies 👋 the commit trail in here was a mess and it had one unaddressed commit both were trivial to fix up though, faster than talking about it really so I just squashed the commits down to the change only, with an updated type per request from @russellwheatley

So if Russell re-reviews and agrees this is good to go

Either way, my re-push had the side effect of re-running CI which means that the patch-package workflow re-runs and - if you follow the details link and check the summary of the patch packages worfklow you should find a patch set you can apply to your project that will work. Providing feedback on how it works is very useful

mikehardy avatar Oct 02 '24 17:10 mikehardy

Amazing, thanks for the extremely quick response, it's much appreciated!

I'll have a look at using patch-package tomorrow.

dannyBies avatar Oct 02 '24 18:10 dannyBies