firestore-ios-sdk-frameworks icon indicating copy to clipboard operation
firestore-ios-sdk-frameworks copied to clipboard

Release script not creating github release, not updating README list of supported tags correctly

Open mikehardy opened this issue 8 months ago • 3 comments

You can see on github releases page that it stopped creating github releases correctly recently (with the 11.9.0 release): https://github.com/invertase/firestore-ios-sdk-frameworks/releases

And you can see on the cocoapods page that the README doesn't have updates after 10.20.0 for supported versions: https://cocoapods.org/pods/FirebaseFirestoreBinary#supported-firebase-ios-sdk-versions

There are also a number of build warnings: https://github.com/invertase/firestore-ios-sdk-frameworks/actions/runs/13644842083/job/38141711437#step:8:207

- NOTE  | xcodebuild:  note: Disabling previews because SWIFT_VERSION is set and SWIFT_OPTIMIZATION_LEVEL=-O, expected -Onone (in target 'FirebaseFirestoreInternalBinary' from project 'Pods')

and

- NOTE  | [iOS] xcodebuild:  Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 11.0, but the range of supported deployment target versions is 12.0 to 18.0.99. (in target 'leveldb-library-leveldb_Privacy' from project 'Pods')

...in a few of the sub-targets, but those two types of errors

mikehardy avatar Mar 20 '25 13:03 mikehardy

May have to do with large file sizes, from latest build run (which ended in failure status):

Unhandled exception: Exception: Committing and publishing failed: remote: warning: See https://gh.io/lfs for more information.
remote: warning: File Archives/grpc.zip is 98.53 MB; this is larger than GitHub's recommended maximum file size of 50.00 MB
remote: warning: GH001: Large files detected. You may want to try Git Large File Storage - https://git-lfs.github.com./

#0 main (file:///Users/runner/work/firestore-ios-sdk-frameworks/firestore-ios-sdk-frameworks/.github/workflows/scripts/framework-controller.dart:172:5)

[!] Calling the GitHub commit API timed out. Please check GitHub’s status at https://status.github.com/ and try again later.
Updating spec repo `cocoapods`
  $ /opt/homebrew/bin/git -C /Users/runner/.cocoapods/repos/cocoapods fetch origin --progress
  $ /opt/homebrew/bin/git -C /Users/runner/.cocoapods/repos/cocoapods rev-parse --abbrev-ref HEAD
  master
  $ /opt/homebrew/bin/git -C /Users/runner/.cocoapods/repos/cocoapods reset --hard origin/master
  HEAD is now at 88e65150bc13 [Add] SIDSDK 1.4.0
Failed to push FirebaseFirestoreInternalBinary

mikehardy avatar Mar 20 '25 14:03 mikehardy

The release script is not idempotent, so now after having failed after pushing some artifacts it appears it will fail every time

Releases here are stuck until this is resolved unfortunately

Failed to push FirebaseFirestoreBinary

https://github.com/invertase/firestore-ios-sdk-frameworks/actions/runs/13970227976/job/39113322395#step:8:211

mikehardy avatar Mar 20 '25 14:03 mikehardy

Interestingly - usable artifacts still appear to have been published - a test integration of 11.10.0 in react-native-firebase appears to be successful:

  • Related https://github.com/invertase/react-native-firebase/pull/8410

mikehardy avatar Mar 20 '25 14:03 mikehardy

....and now the firebase-ios-sdk 11.11.0 release worked fine? Difficult to characterize this one https://github.com/invertase/firestore-ios-sdk-frameworks/actions/runs/14220452667/job/39846898325

mikehardy avatar Apr 02 '25 14:04 mikehardy

Everything seems to be working now after the last few tweaks

mikehardy avatar Aug 04 '25 14:08 mikehardy