dart_firebase_admin icon indicating copy to clipboard operation
dart_firebase_admin copied to clipboard

Published 20 hours ago • verified publisher icon invertase

implement verify method

Open tkfinitefield opened this issue 1 year ago • 6 comments

Fixed issue: Auth#verifyIdToken always throws unimplemented error #20

tkfinitefield avatar May 23 '24 15:05 tkfinitefield

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 23 '24 15:05 CLAassistant

Will it be merged in next release ? Just tried it from commit ref and it is working!

davidcz95 avatar Jun 12 '24 11:06 davidcz95

I'm in holiday at the moment. I'll look at this when I'm back from Japan.

rrousselGit avatar Jun 12 '24 12:06 rrousselGit

Suure, no worries. Have fun there! 🇯🇵

davidcz95 avatar Jun 12 '24 12:06 davidcz95

Hi @rrousselGit , I hope you're enjoying your trip to Japan! Just wanted to gently remind you about this, awaiting your review when you have a chance.

KKimj avatar Jun 28 '24 09:06 KKimj

Looks like this needs testing. My apologies, I should've raised this sooner.

I'll review other PRs and fix other bugs in the meantime. If it's still around by then, I'll consider adding tests for this myself :)

rrousselGit avatar Jul 09 '24 12:07 rrousselGit

This has been sorted in a different PR. Thanks for your work though and sorry for the slow review!

rrousselGit avatar Oct 10 '24 14:10 rrousselGit