dart_firebase_admin icon indicating copy to clipboard operation
dart_firebase_admin copied to clipboard

Published 20 hours ago • verified publisher icon invertase

Fix #21: Pass localId to user update request

Open HeySreelal opened this issue 1 year ago • 4 comments
trafficstars

Fixes #21.

This might a be missed implementation, when sending GoogleCloudIdentitytoolkitV1SetAccountInfoRequest localId (which is basically the UID) was not set to the passed UID. Hence caused #21.

Tested locally, please let me know if we are looking to add tests somehow for this.

Cheers!

HeySreelal avatar Feb 12 '24 15:02 HeySreelal

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 12 '24 15:02 CLAassistant

Hello! Sorry for the delay

Could you add a test for this?

rrousselGit avatar Feb 28 '24 11:02 rrousselGit

Hey @rrousselGit, no problem! I'll quickly add a test for this one.

HeySreelal avatar Feb 28 '24 20:02 HeySreelal

Hi again @rrousselGit, can you please check if the added test case is enough for this? Regards :)

HeySreelal avatar Feb 28 '24 20:02 HeySreelal

LGTM, thanks!

rrousselGit avatar Jul 09 '24 12:07 rrousselGit