dart_edge
dart_edge copied to clipboard
invertase
upgrade to typings
This was in effect a basic replacement of js_bindings with typings Major Changes include:
- No longer using a wrapper over the Request class
- No longer using a wrapper over whatever crypto was
- Removal of RequestDuplex
- Formatting (my formatter's line length is longer, sorry)
@MutantPiggieGolem1 thanks a lot for this.
I've made some changes, primarily reverting the removal of the Request class, since we without it we're depending on the interop layer Request, which (for good reason) doesn't provide a strong type definitions as we'd like and could change at any time.
I have one issue left, the FetchEvent class changes you made wouldn't work, since it creates a circular reference to itself (so Dart thinks it's fixed, when in reality it is not). It seems as though the typings package does not provide the FetchEvent types. It's defined in the TypeScript types here but doesn't seem to be exported to Dart. An issue needs to be made over there (if you could make it, that'd be super useful) to bring it in.
However saying that, I'm not sure whether we actually need it for Dart Edge. It's an API of addEventListener, which we don't seemingly use since we generate the event listener code in JS land via the CLI. So we could get rid of it, as I assume no one is using it?
I've published a new version with bug fixes and WebWorker.
please do some tests and add issues in https://github.com/jodinathan/typings/issues if anything comes up
Hi there,
Just checking here, but do we need additional changes to be made for this PR to be merged?
Any ideas when this PR will be merged? Dart Edge is none functional it doesn't even compile...
Strongly waiting for this PR to be merged or another release from the team. Can't compile more functions until this typings migration is done.
@Ehesp can you get the PRs on this project some attention? It would be great to merge some and get a new release!
