invenio-app-rdm icon indicating copy to clipboard operation
invenio-app-rdm copied to clipboard

Creating access token via ui does not lead back to the application overview

Open ghost opened this issue 3 years ago • 6 comments

Package version (if known): v7 (but also older versions had this issue)

Describe the bug

When creating an access token the last step does not lead back to the Application overview but shows me a 'save'-button that does nothing? or it does something and the user does not get informed that is does something - you will stay on the same page and can click the button several times with no change.

Steps to Reproduce

  1. Sign up https://inveniordm.web.cern.ch/signup/
  2. Go to 'Applications' (drop down on the signed up account)
  3. Create an access token:
  • Click here on 'New token': 01-step
  • Add a name and click 'Create': 02-step
  • Click on 'Save' 03-step
  • Leads to: 04-step

Expected behavior

I'm not sure whether the 'save' button on the last step leads to something - if it is needed, then after clicking it you might should get back to the 'Applications' overview.

05-step

Currently you have to click on any of the other menu to be able to 'reload' or select again the 'Applications' view.

ghost avatar Dec 08 '21 14:12 ghost

This issue was automatically marked as stale.

github-actions[bot] avatar Feb 07 '22 06:02 github-actions[bot]

The save button allows you to change the scopes (currently only one today) and the name of the token so I think it's correct that it stays on the page.

lnielsen avatar Feb 09 '22 09:02 lnielsen

I disagree. After the creation of a token you are not able to come back to this page in a reasonable way:

image

You stay on the page with the token:

image

The only way to come back to the 'Applications'-Overview is by reloading your whole page, or by clicking on some of the other menu (profile, change password, ...) and then click again on 'applications'.

ghost avatar Feb 16 '22 09:02 ghost

The current behaviour of save button in other places in Invenio is that it stays on the detail page that you're editing so I don't want to change this part of the behaviour.

We can either make "Applications" linked or add a third button saying staying e.g. "Cance"l that will lead back.

lnielsen avatar Feb 16 '22 11:02 lnielsen

Interesting view --- since the 'save' and 'delete' is on the bottom of the page - my mind decided/expected that after a 'save' the page is gone. Just as with popup windows (e.g. adding a creator - where with the save the window is gone). It would never had come to my mind to see this page as the 'records-draft' page, where the 'publish' leads to the published landing page.

'Cancel' feels wrong for me... Because I just created a token, saved it and I wouldn't know what to expect what 'cancel' then means.

A button 'back to the overview' or making 'Applications' to be clicked again to get on the overview would make sense for me.

ghost avatar Feb 16 '22 12:02 ghost

This issue was automatically marked as stale.

github-actions[bot] avatar Apr 18 '22 06:04 github-actions[bot]