graphql-filter-java icon indicating copy to clipboard operation
graphql-filter-java copied to clipboard

Published 20 hours ago • verified publisher icon intuit

Add null equality to EQ JPA expression visitor

Open tinawu0603 opened this issue 3 years ago • 3 comments

1. Issue Link: https://github.com/intuit/graphql-filter-java/issues/23

2. Brief explanation of a change: Instead of assuming all values of eq to use criteriaBuilder.equal, if the value is null, we want to use criteriaBuilder.isNull instead to create the right specification.

3. Will it break existing clients and code in production? No

tinawu0603 avatar Aug 19 '22 20:08 tinawu0603

@jaiswalsk would you be able to review this PR?

tinawu0603 avatar Aug 22 '22 15:08 tinawu0603

Thank you @tinawu0603 for the pull request. I will review this and share my feedback soon! Thanks.

jaiswalsk avatar Aug 25 '22 23:08 jaiswalsk

@jaiswalsk Do you have an update for this PR? 🙏

tinawu0603 avatar Aug 31 '22 17:08 tinawu0603