QuickBooks-V3-DotNET-SDK icon indicating copy to clipboard operation
QuickBooks-V3-DotNET-SDK copied to clipboard

Published 20 hours ago • verified publisher icon intuit

Please remove serilog dependencies

Open smasherprog opened this issue 2 years ago • 14 comments
trafficstars

We have been bitten by this again in a recent release. This logging library should NOT be a dependency in your nuget package.

smasherprog avatar Jul 06 '23 13:07 smasherprog

We are currently going into a freeze on updates to quickbooks library due to issues with serilog.

Server Error in '/' Application. Method not found: 'Serilog.LoggerConfiguration Serilog.FileLoggerConfigurationExtensions.File(Serilog.Configuration.LoggerSinkConfiguration, System.String, Serilog.Events.LogEventLevel, System.String, System.IFormatProvider, System.Nullable1<Int64>, Serilog.Core.LoggingLevelSwitch, Boolean, Boolean, System.Nullable1<System.TimeSpan>, Serilog.RollingInterval, Boolean, System.Nullable`1<Int32>, System.Text.Encoding, Serilog.Sinks.File.FileLifecycleHooks)'.

smasherprog avatar Jul 06 '23 14:07 smasherprog

Quickbooks is not adding version ranges to their nuget package for their dependencies. This has been going on for years now?

smasherprog avatar Jul 06 '23 14:07 smasherprog

Yes. Years.

redhorseck avatar Aug 12 '23 16:08 redhorseck

I don't understand why they took a hard dependency on Serilog (and a specific version at that). This is exactly why libraries should code against the M$ ILogger interface, even if it's less ideal than using Serilog directly. This has us unable to upgrade the SDK and we can't pin our version of Serilog to what they are using.

eswann avatar Aug 17 '23 22:08 eswann

Depending on your needs, you might want to consider using the community .NET SDK QuickBooksSharp. It has a much lighter footprint and a more modern API up to date with latest .NET practices. Disclaimer: I maintain this library.

clement911 avatar Aug 17 '23 22:08 clement911

Thanks I will check it out again. I had look at it but the last update was 9 months ago so I wasn't sure if it was still being maintained. Good to hear that it is.

redhorseck avatar Aug 17 '23 22:08 redhorseck

@clement911 I would check it out, but for us there is already a lot of code using the existing SDK, and don't have the time (or permission) to rewrite all of it to use a different library.

eswann avatar Aug 18 '23 13:08 eswann

Is there any update on the request. It stopping us from using the latest version.

attahameed avatar Mar 21 '24 18:03 attahameed

Why is this library using Serilog rather than Microsoft Extensions Logging? If NOTHING else, this should be an optional dependency.

drusellers avatar Apr 12 '24 01:04 drusellers

Still not fixed. What version of this 'Serilog.Sinks.File' dll is expected?

xosevilla avatar Apr 17 '24 14:04 xosevilla

I had some hope that with 14.6.3.7 dropping recently that we might be able to update Serilog.Sinks.Seq with it, but still stuck 😓

CyanideMonkey avatar Jun 19 '24 05:06 CyanideMonkey