Jolyn

Results 264 comments of Jolyn

I've considered making this change as well, in the past. The create-single-spa CLI uses libraryTarget of `system` as it's default for root configs, react applications, and utility modules. The vue-cli-plugin-single-spa...

I'm open to adding this in our next major. There are no plans right now for a new major version, and it gets tricky because single-spa-angular@3 serves Angular 1-8 apps,...

I don't spend much time maintaining single-spa-angular, and there aren't many other maintainers who help with it. I review pull requests and try to encourage others to help maintain single-spa-angular,...

I pulled down your code to add tests to it, but was unable to reproduce the problem in tests. Could you please provide a demonstration of the repo? Before merging...

Hi @lsphillips, I'm open to this change, as I don't see a reason to forbid transformation/processing of the single-spa props. The `handleProps` name matches the pattern set by `handleInstance`, which...

I have diagnosed some vue router problems for Vue 3 in other issues, but didn't easily find the links to those issues. The issue you linked to is for Vue...

This sounds like the typescript definitions need to be updated. Here's the file where they can be updated: https://github.com/single-spa/single-spa-vue/blob/main/types/single-spa-vue.d.ts The single-spa library has the default props defined at https://github.com/single-spa/single-spa/blob/f67d6fcd404597a246636e302f1d9e7b0f8cd9c6/typings/single-spa.d.ts#L12 -...

I think the best solution would be to type the `render` function properly. Typecasting with `(this)` is a workaround, but the full solution is to change the function signature. The...

Hi @exaucae, can you help with the French translation? Do you know anyone else who can help with the translation? We prefer having at least two people helping with the...

Sure @exaucae, I've created https://github.com/single-spa/fr.single-spa.js.org and started the process. The remaining steps require a couple days to go through, so I'll plan on coming back to this over time. Feel...