ember-href-to
ember-href-to copied to clipboard
intercom
Add support for routable engines
Make {{href-to}} act like {{link-to}} does within an engine, automatically prefixing routes with the engine's namespace.
Add {{href-to-external}} helper, for linking to routes in an engine's host app. Acts like {{link-to-external}}.
This is a breaking change for anyone using {{href-to}} within an engine to link to routes in the host app, but that seems like an uncommon case.
I was not sure how to write tests that pretend to be in an engine, suggestions are welcome.
I was not sure how to write tests that pretend to be in an engine, suggestions are welcome.
I'm not familiar with engines so I don't have any good suggestions. Perhaps there are some tests in https://github.com/ember-engines/ember-engines that will serve as a guide?
@aaxelb - You need to add export { default } from 'ember-href-to/helpers/href-to-external' to app/helpers/href-to-external.js.
Apart from that, this seems to work!
rebas'd to resolve conflicts!
tho now the build is failing for node version reasons:
error [email protected]: The engine "node" is incompatible with this module. Expected version "8.* || 10.* || >= 12.*". Got "6.17.1"
I've created PR #128 to just bump the Node.js version to 8 in .travis.yaml.
@aaxelb can you rebase? #128 was merged and should fix the Node.js version issue.
