Elliot.

Results 305 comments of Elliot.

- awaiting perf team sign-off - Internal tracker: RPFC-90

- Price oracles haven't been been partner tested or Devnet released yet - Let's put this in 2.2 (or later)

No. I would suggest running it in a new Devnet (similar to what was done with amm-devnet). If that isn't possible, then we can do a custom build with this...

per the request for a quick re-review (see above), this is awaiting @thejohnfreeman

Writing this info to a log file seems best, but we don't want to create another log. We should be able to estimate the file's rate of growth. Could offer...

I think we should consider deprecating sign-and-submit mode, and create an issue for building a separate signing tool. The separate signing tool can be implemented in C++ or in TypeScript....

Users _should_ use public key cryptography the way it was intended to be used: the private key always remains private and should never be transmitted. Transaction signing can, and should,...

Much of the team is currently on vacation. We will certainly have a look at this in January. Thanks for the ping! Internal tracker: RPFC-86

@sublimator as these changes are expected to impact performance, please provide these details for the performance team to understand and test: 1. Is this a new feature, bug fix, or...

notes: - some community members have a concern about `CheckCashMakesTrustline` because of the trust line bloat issue. - trust lines comprise >56% of all ledger data. - in addition to...