Elliot.

@seelabs : > Did a pass. I'll come back and do another pass later, but I wanted to get the current set of comments in now. Are you still planning...

@ximinez @scottschurr What's your opinion? Perhaps, after taking a step back and considering all the effort required (including reviews), we've learned that this refactor is not worthwhile at this time?

1. need estimate of how much time this would take 2. need recommended prioritization vs OKRs and goals

- want the interface across all objects to be uniform. This PR only changes AcctRoot, but there are many other types of ledger objects. - to have a consistent interface...

Given the benefits to these changes aren't crystal clear, I'm happy to go with @scottschurr and @ckeshava 's recommendation. If you feel that we've learned enough for now and no...

@scottschurr for suggested changes that have been addressed, can you click the `Resolve conversation` button in GitHub to collapse them? Thanks!

@RichardAH feel free to review this, at your convenience.

Feel free to say no, but: Is there a way to divide this into 2 smaller PRs so that review is easier? We can have a feature branch (similar to...

If and when this PR is merged: 1. It will be squashed into a single commit. 2. The commit will have the following commit message: ``` Introduce AMM support (XLS-30d):...

per community discussions, this will not be merged until after the results of the security review are published (cc: @injaelee )