neural-compressor icon indicating copy to clipboard operation
neural-compressor copied to clipboard

Remove 1x

Open yiliu30 opened this issue 1 year ago • 4 comments

Remove 1.x related code

Some folders and files include both 1.x and 2.x UTs. I've removed the 1.x UTs if they import something from experimental or conf. Please help double-check. Thanks!

  • [x] ORT @mengniwang95 @yuwenzho
  • [ ] Torch @xin3he @PenghuiCheng
  • [x] TF @zehao-intel
  • [ ] Pruning @wenhuach21 @yintong-lu
  • [ ] NAS, distillation @XinyuYe-Intel

Track some changes:

@chensuyue @XuehaoSun , need your help to update the CI for the below changes:

  • [x] Model-Test (Run PyTorch Model resnet18) is 1.x example. https://github.com/intel/neural-compressor/pull/1898
  • [x] ~~All tfnewapi UTs are based on the 1.x, should we remove the CI for it?~~
  • [x] All nas-relaed UTs have been removed, need to update the base_api CI. https://github.com/intel/neural-compressor/pull/1896

@changwangss , need your help to clean some code on itrex side.

  • [x] Replace from neural_compressor.conf.dotdict import DotDict with from neural_compressor.utils.utility import DotDict https://github.com/intel/intel-extension-for-transformers/pull/1645
  • [x] Update from neural_compressor.experimental import common https://github.com/intel/intel-extension-for-transformers/pull/1645

optimum-intel @changwangss

  • [ ] update from neural_compressor.experimental.export import torch_to_int8_onnx, https://github.com/huggingface/optimum-intel/pull/777 updated it, but ITREX CI uses optimum-intel==1.16.1. https://github.com/intel/intel-extension-for-transformers/pull/1651

  • [ ] Delete docs by separate PRs. @yiliu30 https://github.com/intel/neural-compressor/pull/1900

Dependency Change?

any library dependency introduced or removed

yiliu30 avatar Jun 14 '24 02:06 yiliu30

⛈️ Required checks status: Has failure 🔴

Warning If you do not have the access to re-run the Probot, please contact XuehaoSun for help. If you push a new commit, all of the workflow will be re-triggered.

Groups summary

🟢 Code Scan Tests workflow
Check ID Status Error details
Code-Scan success
Code-Scan (Bandit Code Scan Bandit) success
Code-Scan (DocStyle Code Scan DocStyle) success
Code-Scan (Pylint Code Scan Pylint) success

These checks are required after the changes to neural_compressor/adaptor/keras.py, neural_compressor/adaptor/mxnet.py, neural_compressor/adaptor/onnxrt.py, neural_compressor/adaptor/pytorch.py, neural_compressor/adaptor/tensorflow.py, neural_compressor/adaptor/tf_utils/graph_converter.py, neural_compressor/adaptor/tf_utils/graph_converter_without_calib.py, neural_compressor/compression/pruner/utils.py, neural_compressor/conf/README.md, neural_compressor/conf/__init__.py, neural_compressor/conf/config.py, neural_compressor/conf/dotdict.py, neural_compressor/conf/pythonic_config.py, neural_compressor/experimental/__init__.py, neural_compressor/experimental/benchmark.py, neural_compressor/experimental/common/__init__.py, neural_compressor/experimental/common/criterion.py, neural_compressor/experimental/common/dataloader.py, neural_compressor/experimental/common/metric.py, neural_compressor/experimental/common/model.py and 98 more files...

🔴 Model Tests workflow
Check ID Status Error details
Model-Test failure
Model-Test (Generate Report GenerateReport) no_status
Model-Test (Run ONNX Model resnet50-v1-12) failure
Model-Test (Run PyTorch Model resnet18_fx) failure
Model-Test (Run TensorFlow Model resnet50v1.5) failure
Model-Test (Run TensorFlow Model ssd_resnet50_v1) failure

These checks are required after the changes to neural_compressor/adaptor/keras.py, neural_compressor/adaptor/mxnet.py, neural_compressor/adaptor/onnxrt.py, neural_compressor/adaptor/pytorch.py, neural_compressor/adaptor/tensorflow.py, neural_compressor/adaptor/tf_utils/graph_converter.py, neural_compressor/adaptor/tf_utils/graph_converter_without_calib.py, neural_compressor/compression/pruner/utils.py, neural_compressor/conf/README.md, neural_compressor/conf/__init__.py, neural_compressor/conf/config.py, neural_compressor/conf/dotdict.py, neural_compressor/conf/pythonic_config.py, neural_compressor/experimental/__init__.py, neural_compressor/experimental/benchmark.py, neural_compressor/experimental/common/__init__.py, neural_compressor/experimental/common/criterion.py, neural_compressor/experimental/common/dataloader.py, neural_compressor/experimental/common/metric.py, neural_compressor/experimental/common/model.py and 98 more files...

🔴 Unit Tests basic workflow
Check ID Status Error details
UT-Basic failure
UT-Basic (Coverage Compare CollectDatafiles) no_status
UT-Basic (Unit Test FWKs adaptor Test FWKs adaptor) failure
UT-Basic (Unit Test FWKs adaptor baseline Test FWKs adaptor baseline) success
UT-Basic (Unit Test ITEX Test ITEX) failure
UT-Basic (Unit Test ITEX baseline Test ITEX baseline) success
UT-Basic (Unit Test Pruning Test PyTorch Pruning) success
UT-Basic (Unit Test Pruning Test TensorFlow Pruning) success
UT-Basic (Unit Test Pruning baseline Test PyTorch Pruning baseline) success
UT-Basic (Unit Test Pruning baseline Test TensorFlow Pruning baseline) success
UT-Basic (Unit Test TF newAPI Test TF newAPI) success
UT-Basic (Unit Test TF newAPI baseline Test TF newAPI baseline) success
UT-Basic (Unit Test User facing API Test User facing API) failure
UT-Basic (Unit Test User facing API baseline Test User facing API baseline) success
UT-Basic (Unit Test other basic case Test other basic case) failure
UT-Basic (Unit Test other cases baseline Test other cases baseline) success

These checks are required after the changes to neural_compressor/adaptor/keras.py, neural_compressor/adaptor/mxnet.py, neural_compressor/adaptor/onnxrt.py, neural_compressor/adaptor/pytorch.py, neural_compressor/adaptor/tensorflow.py, neural_compressor/adaptor/tf_utils/graph_converter.py, neural_compressor/adaptor/tf_utils/graph_converter_without_calib.py, neural_compressor/compression/pruner/utils.py, neural_compressor/conf/README.md, neural_compressor/conf/__init__.py, neural_compressor/conf/config.py, neural_compressor/conf/dotdict.py, neural_compressor/conf/pythonic_config.py, neural_compressor/experimental/__init__.py, neural_compressor/experimental/benchmark.py, neural_compressor/experimental/common/__init__.py, neural_compressor/experimental/common/criterion.py, neural_compressor/experimental/common/dataloader.py, neural_compressor/experimental/common/metric.py, neural_compressor/experimental/common/model.py and 203 more files...

🔴 Unit Tests basic no coverage workflow
Check ID Status Error details
UT-Basic-No-Coverage failure
UT-Basic-No-Coverage (Unit Test FWKs adaptor Test FWKs adaptor) failure
UT-Basic-No-Coverage (Unit Test Pruning Test PyTorch Pruning) failure
UT-Basic-No-Coverage (Unit Test Pruning Test TensorFlow Pruning) failure
UT-Basic-No-Coverage (Unit Test User facing API Test User facing API) failure
UT-Basic-No-Coverage (Unit Test other basic case Test other basic case) failure

These checks are required after the changes to neural_compressor/adaptor/keras.py, neural_compressor/adaptor/mxnet.py, neural_compressor/adaptor/onnxrt.py, neural_compressor/adaptor/pytorch.py, neural_compressor/adaptor/tensorflow.py, neural_compressor/adaptor/tf_utils/graph_converter.py, neural_compressor/adaptor/tf_utils/graph_converter_without_calib.py, neural_compressor/compression/pruner/utils.py, neural_compressor/conf/README.md, neural_compressor/conf/__init__.py, neural_compressor/conf/config.py, neural_compressor/conf/dotdict.py, neural_compressor/conf/pythonic_config.py, neural_compressor/experimental/__init__.py, neural_compressor/experimental/benchmark.py, neural_compressor/experimental/common/__init__.py, neural_compressor/experimental/common/criterion.py, neural_compressor/experimental/common/dataloader.py, neural_compressor/experimental/common/metric.py, neural_compressor/experimental/common/model.py and 203 more files...

🔴 Unit Tests ITREX workflow
Check ID Status Error details
UT-ITREX failure

These checks are required after the changes to neural_compressor/adaptor/keras.py, neural_compressor/adaptor/mxnet.py, neural_compressor/adaptor/onnxrt.py, neural_compressor/adaptor/pytorch.py, neural_compressor/adaptor/tensorflow.py, neural_compressor/adaptor/tf_utils/graph_converter.py, neural_compressor/adaptor/tf_utils/graph_converter_without_calib.py, neural_compressor/compression/pruner/utils.py, neural_compressor/conf/README.md, neural_compressor/conf/__init__.py, neural_compressor/conf/config.py, neural_compressor/conf/dotdict.py, neural_compressor/conf/pythonic_config.py, neural_compressor/experimental/__init__.py, neural_compressor/experimental/benchmark.py, neural_compressor/experimental/common/__init__.py, neural_compressor/experimental/common/criterion.py, neural_compressor/experimental/common/dataloader.py, neural_compressor/experimental/common/metric.py, neural_compressor/experimental/common/model.py and 98 more files...


Thank you for your contribution! 💜

Note This comment is automatically generated and will be updates every 180 seconds within the next 6 hours. If you have any other questions, contact chensuyue or XuehaoSun for help.

github-actions[bot] avatar Jun 15 '24 03:06 github-actions[bot]

please also delete related doc

mengniwang95 avatar Jul 03 '24 02:07 mengniwang95

please also delete related doc

Sure, will delete docs by separate PRs.

yiliu30 avatar Jul 03 '24 03:07 yiliu30

compare coverage
PR lines coverage: 31017/41008 (75.636%)
PR branches coverage: 10786/16871 (63.932%)
BASE lines coverage: 44335/52654 (84.201%)
BASE branches coverage: 15819/21486 (73.625%)
clear upload path
Unit Test failed with lines coverage decrease -8.565%
Unit Test failed with branches coverage decrease -9.693%
compare coverage to give detail info

yiliu30 avatar Jul 03 '24 11:07 yiliu30

@n1ck-guo Please help review the pruning code. I have read through it, but I am not very familiar with it anymore.

wenhuach21 avatar Jul 05 '24 06:07 wenhuach21