llvm
llvm copied to clipboard
intel
Add the remaining diagnostics to device_global implementation
This PR is a follow up to PR #5597 to implement the diagnostics not covered in #5597
As it stands currently, this PR includes implementation for cases described in this documentation and their templated versions - https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_device_global.asciidoc#restrictions-on-creating-device-global-objects except the shadow variable/namespace case. Specifically, it covers five cases where device_global is declared as a private member inside a struct and within methods inside struct, their template versions/instantiation and inside a shadow namespace.
Work in progress - shadow variable/namespace case. Description to be updated once that is done.
@schittir could you please update the PR description with a list of all required diagnostics for device_global. Please mention which of these have already been implemented in the previous patch and which ones are covered in this patch. If any are yet to be implemented, please include that as well.
@schittir could you please update the PR description with a list of all required diagnostics for device_global. Please mention which of these have already been implemented in the previous patch and which ones are covered in this patch. If any are yet to be implemented, please include that as well.
@schittir can you update the PR description ASAP. It will help with review and I can start looking into diagnostics already implemented in this PR.
@schittir could you please update the PR description with a list of all required diagnostics for device_global. Please mention which of these have already been implemented in the previous patch and which ones are covered in this patch. If any are yet to be implemented, please include that as well.
@schittir could you please update the PR description with a list of all required diagnostics for device_global. Please mention which of these have already been implemented in the previous patch and which ones are covered in this patch. If any are yet to be implemented, please include that as well.
@schittir can you update the PR description ASAP. It will help with review and I can start looking into diagnostics already implemented in this PR.
@elizabethandrews You should see the description updated now. Sorry I mistakenly thought that I already did that. Also I didn't think that it was holding you from reviewing it. Please take a look and let me know if anything else needs to be clarified. Thank you!
IIUC, you haven't implemented support for shadowed device_global variables right?
