llvm
llvm copied to clipboard
intel
[AsyncAlloc][SYCL][ABI-BREAK] Use the SYCL properties extension for memory pool creation
Introduce initial_threshold, maximum_size, read_only, and zero_init runtime properties conforming to the SYCL properties extension, and apply these properties to the creation of memory pools.
This PR is a draft until the feature has been added to the sycl_ext_oneapi_async_memory_alloc spec.
We are not allowed to break ABI outside of the window, is it possible to guard the breaking changes with __INTEL_PREVIEW_BREAKING_CHANGES macro?
@omarahmed1111 @Seanst98 I'm very sorry, I completely missed that this is an experimental extension which has been just recently implemented (so, as far as I understand it hasn't even made it to the previous release). For experimental extensions it is allowed to break ABI, so initial version of the PR was good (i.e. there is no necessity to guard with __INTEL_PREVIEW_BREAKING_CHANGES). Again, really sorry for false alarm
@omarahmed1111 @Seanst98 I'm very sorry, I completely missed that this is an experimental extension which has been just recently implemented (so, as far as I understand it hasn't even made it to the previous release). For experimental extensions it is allowed to break ABI, so initial version of the PR was good (i.e. there is no necessity to guard with __INTEL_PREVIEW_BREAKING_CHANGES). Again, really sorry for false alarm
No worries, I just reverted the __INTEL_PREVIEW_BREAKING_CHANGES changes and refactored how we represent props from a pair of tuples to a struct of pairs.
@againull @Bensuo I added a new changes as the spec was modified recently and merged, so the changes here should match that. would be great to have another look, Thanks!