llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL] Fix device assertion bug on windows

Open lbushi25 opened this issue 1 year ago • 5 comments

This PR fixes a device assertion bug on Windows where the assertion message and information are not printed when an assertion is triggered. Also re-enabled some tests failing because of it. See https://github.com/intel/llvm/issues/12797.

lbushi25 avatar Aug 26 '24 20:08 lbushi25

Please fix formatting, other than that LGTM.

Done!

lbushi25 avatar Aug 26 '24 20:08 lbushi25

@intel/llvm-gatekeepers This is ready for merge. All failures are infrastructure related in the cleanup stage. Update: I restarted the failing tasks just to have success so thats why it shows that some tasks are not complete but there are no functional failures so we can proceed with merge.

lbushi25 avatar Aug 27 '24 05:08 lbushi25

@intel/llvm-gatekeepers ping

lbushi25 avatar Aug 28 '24 17:08 lbushi25

@intel/llvm-gatekeepers ping

Please fix:

image

aelovikov-intel avatar Aug 28 '24 17:08 aelovikov-intel

@intel/llvm-gatekeepers ping

Please fix:

image

I haven't seen this before. Where is it from and how can I fix it?

lbushi25 avatar Aug 28 '24 17:08 lbushi25

Reminder to close #12797 once this is merged.

lbushi25 avatar Aug 29 '24 04:08 lbushi25

@intel/llvm-gatekeepers ping

Please fix: image

I haven't seen this before. Where is it from and how can I fix it?

https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address mentions a "noreply" github email. You may have to edit some of your github settings.

steffenlarsen avatar Aug 29 '24 14:08 steffenlarsen

Opened another clone here with hopefully proper email this time: https://github.com/intel/llvm/pull/15232. Closing this.

lbushi25 avatar Aug 29 '24 19:08 lbushi25