llvm icon indicating copy to clipboard operation
llvm copied to clipboard

Published 20 hours ago • verified publisher icon intel

[DeviceSanitizer] Disable ASan when the ESIMD kernel is found

Open AllanZyne opened this issue 1 year ago • 4 comments

ESIMD kernel doesn't support noinline functions, so we can't support sanitizer for it now.

We can't check if the kernel is ESIMD kernel at Unified Runtime, so we have to disable ASan completely when it found ESIMD kernel in device image.

AllanZyne avatar Jun 13 '24 05:06 AllanZyne

add a lit test?

Done

AllanZyne avatar Jun 25 '24 05:06 AllanZyne

Hi @intel/llvm-gatekeepers, can you please merge this PR? I'm sure the failed CI test is not related to this PR. Thanks!

AllanZyne avatar Jun 27 '24 10:06 AllanZyne

Assert/assert_in_simultaneous_kernels.cpp failed on OpenCL CPU. It is not a failure I have seen before. Could you please make sure it is flaky and unrelated? If it is, we should open an issue for it.

steffenlarsen avatar Jun 27 '24 10:06 steffenlarsen

Assert/assert_in_simultaneous_kernels.cpp failed on OpenCL CPU. It is not a failure I have seen before. Could you please make sure it is flaky and unrelated? If it is, we should open an issue for it.

Yes, it is flaky and unrelated.

AllanZyne avatar Jun 28 '24 05:06 AllanZyne

Hi @steffenlarsen, I merged this PR to latest code and that test failure has disappeared. Maybe it has fixed by other PR. So can you approve to merge this PR?

AllanZyne avatar Jul 02 '24 10:07 AllanZyne