llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL][Bindless][Exp] Remove unneeded function argument causing memory leak in image create functions

Open DBDuncan opened this issue 1 year ago • 1 comments
trafficstars

Remove pi_mem argument from piextMemUnsampledImageCreate, piextMemSampledImageCreate and the corresponding UR functions. The argument is not used for any useful functionality and causes a memory leak.

DBDuncan avatar Apr 11 '24 14:04 DBDuncan

Corresponding UR PR: https://github.com/oneapi-src/unified-runtime/pull/1512

DBDuncan avatar Apr 11 '24 14:04 DBDuncan

https://github.com/intel/llvm/pull/13503 which fixes the ASAN test failures here have now been merged, pull in the latest sycl branch changes to get the check passing.

kbenzie avatar May 16 '24 10:05 kbenzie

@intel/llvm-gatekeepers please merge

kbenzie avatar May 17 '24 19:05 kbenzie

We aren't merging any PRs today because the CI is in a bad state, we will merge this on Monday.

sarnex avatar May 17 '24 19:05 sarnex

@sarnex Is CI in a better state now?

DBDuncan avatar May 20 '24 12:05 DBDuncan

@sarnex Is CI in a better state now?

Let's see :)

aelovikov-intel avatar May 20 '24 14:05 aelovikov-intel