llvm icon indicating copy to clipboard operation
llvm copied to clipboard

Align terminology used by ONEAPI_DEVICE_FILTER and SYCL_DEVICE_ALLOWLIST

Open uditagarwal97 opened this issue 1 year ago • 4 comments

Currently, SYCL_DEVICE_ALLOWLIST uses 'acc' to select accelerator device type while ONEAPI_DEVICE_FILTER uses 'fpga' for the same. I propose that we also update SYCL_DEVICE_ALLOWLIST to use 'fpga' instead of 'acc'. Not only this will make the terminology consistent, it will also simplify the code as some functions are common between SYCL_DEVICE_ALLOWLIST and ONEAPI_DEVICE_FILTER .

uditagarwal97 avatar Feb 06 '24 19:02 uditagarwal97

@aelovikov-intel @gmlueck thoughts?

uditagarwal97 avatar Feb 06 '24 19:02 uditagarwal97

+ @steffenlarsen @sergey-semenov

aelovikov-intel avatar Feb 06 '24 20:02 aelovikov-intel

I think this is a reasonable idea, but maybe we should just allow both? The reason we use acc is because it is one of the 4 device types in SYCL: cpu, gpu, accelerator and custom (ignoring host, automatic and all). Since ONEAPI_DEVICE_SELECTOR isn't SYCL-specific, we do not have full control over it, so picking accelerator devices when fpga is specified is something we will have to live with, but SYCL_DEVICE_ALLOWLIST is, as the name suggests, SYCL specific, so I would prefer we at least let users use SYCL terminology if they intend to use it.

steffenlarsen avatar Feb 06 '24 20:02 steffenlarsen

OK with me.

gmlueck avatar Feb 12 '24 22:02 gmlueck