llvm icon indicating copy to clipboard operation
llvm copied to clipboard

Published 20 hours ago • verified publisher icon intel

[SYCL][Bindless][Exp] Add Support For Unsampled Image Arrays

Open isaacault opened this issue 1 year ago • 2 comments
trafficstars

  • Creation / destruction of unsampled image arrays
  • Reading / writing of unsampled image arrays
  • sycl::ext::oneapi::experimental::image_type::array enum value added
  • sycl::ext::oneapi::experimental::image_descriptor::array_size member added
  • sycl::ext::oneapi::experimental::image_descriptor::verify() member function added

Correlated UR PR: [Bindless][Exp] Add Support For Image Arrays #1274

isaacault avatar Jan 23 '24 12:01 isaacault

@jchlanda My apologies, I accidentally rebased. I believe I've corrected my mistake, and you can see my changes addressing your feedback in 6b2ca14.

isaacault avatar Feb 06 '24 14:02 isaacault

@jchlanda My apologies, I accidentally rebased. I believe I've corrected my mistake, and you can see my changes addressing your feedback in 6b2ca14.

Not a problem, I've left one more question, otherwise the libclc part looks good. Thank you.

jchlanda avatar Feb 07 '24 09:02 jchlanda

@intel/llvm-gatekeepers Can this get merged? CI failure unrelated & already reported in https://github.com/intel/llvm/issues/12797 and https://github.com/intel/llvm/issues/12798

isaacault avatar Feb 23 '24 18:02 isaacault

@intel/llvm-gatekeepers please merge, the Windows failure is being tracked in #12798

kbenzie avatar Feb 26 '24 15:02 kbenzie