llvm icon indicating copy to clipboard operation
llvm copied to clipboard

vec (+swizzle) and annotated_arg should define their binary operators as hidden friends

Open rolandschulz opened this issue 1 year ago • 1 comments

Both vec (+swizzle) and annotated_arg don't define the their binary operators as hidden friends. For vec the spec is clear that it should be a hidden friend. For annotated_arg we should make this clear.

Originally posted by @rolandschulz in https://github.com/intel/llvm/pull/11971#discussion_r1416679574

rolandschulz avatar Dec 06 '23 05:12 rolandschulz

For vec and swizzle this is addressed in https://github.com/intel/llvm/pull/12396.

steffenlarsen avatar Jan 17 '24 16:01 steffenlarsen

These have been addressed:

  • vec: https://github.com/intel/llvm/pull/12396
  • Swizzles: https://github.com/intel/llvm/pull/13012
  • annotated_arg: https://github.com/intel/llvm/pull/12232

@rolandschulz - I will close this. Please reopen if you believe we missed something.

steffenlarsen avatar Aug 12 '24 13:08 steffenlarsen