intel-device-plugins-for-kubernetes icon indicating copy to clipboard operation
intel-device-plugins-for-kubernetes copied to clipboard

Use more linters for CI check

Open bart0sh opened this issue 3 years ago • 1 comments

Currently we use 35 out of 95 (see below) available linters in our CI lint check. We either need to regularly revisit that list and update linters or enable all of them by default and only disable those that we don't want to use, explaining the reason in the config file. Later would be preferable from my point of view.

List of available linters for the time of writing this issue:

[asasalint asciicheck bidichk bodyclose containedctx contextcheck cyclop deadcode decorder depguard dogsled dupl durationcheck errcheck errchkjson errname errorlint execinquery exhaustive exhaustivestruct exhaustruct exportloopref forbidigo forcetypeassert funlen gci gochecknoglobals gochecknoinits gocognit goconst gocritic gocyclo godot godox goerr113 gofmt gofumpt goheader goimports golint gomnd gomoddirectives gomodguard goprintffuncname gosec gosimple govet grouper ifshort importas ineffassign interfacer ireturn lll maintidx makezero maligned misspell nakedret nestif nilerr nilnil nlreturn noctx nolintlint nonamedreturns nosnakecase nosprintfhostport paralleltest prealloc predeclared promlinter revive rowserrcheck scopelint sqlclosecheck staticcheck structcheck stylecheck tagliatelle tenv testpackage thelper tparallel typecheck unconvert unparam unused usestdlibvars varcheck varnamelen wastedassign whitespace wrapcheck wsl] 

List of used linters:

[asciicheck bodyclose deadcode dogsled errcheck exportloopref gocognit goconst gocyclo godot goerr113 gofmt goimports gomodguard goprintffuncname gosec gosimple govet ineffassign misspell nakedret noctx nolintlint prealloc revive rowserrcheck staticcheck structcheck stylecheck typecheck unconvert unused varcheck whitespace wsl]

bart0sh avatar Sep 02 '22 09:09 bart0sh

  • and drop the ones that are disabled and trigger a warning

mythi avatar Sep 07 '22 05:09 mythi