terraform-provider-github
terraform-provider-github copied to clipboard
Add missed parameter to the github_organization_ruleset
Resolves #2542
Before the change?
- No parameter in
github_organization_rulesetthat cause an error, as it's required inrespository_rules_utils.expandRules
After the change?
- The parameter is added to the
github_organization_rulesetwith the default value
Pull request checklist
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
- [ ] Yes
- [x] No
It would be nice to have this merged. Can someone review it?
@kfcampbell Can we please get this fix merged and released?
Hi @kfcampbell can you please review and merge this?
@yurii-kysel Should probably also update https://github.com/integrations/terraform-provider-github/blob/main/website/docs/r/organization_ruleset.html.markdown in this PR, too
fairly sure this PR fixes https://github.com/integrations/terraform-provider-github/issues/2597 - would be great to have it approved/merged :)
oh and https://github.com/integrations/terraform-provider-github/issues/2542 would get closed out too (already linked)
None of that matters unless M$ Github actually allocates time for their people to merge PRs. Plenty of us are actual paying GHE customers and are being ignored.