terraform-provider-github icon indicating copy to clipboard operation
terraform-provider-github copied to clipboard

Add missed parameter to the github_organization_ruleset

Open yurii-kysel opened this issue 10 months ago • 6 comments

Resolves #2542


Before the change?

  • No parameter in github_organization_ruleset that cause an error, as it's required in respository_rules_utils.expandRules

After the change?

  • The parameter is added to the github_organization_ruleset with the default value

Pull request checklist

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • [ ] Yes
  • [x] No

yurii-kysel avatar Jan 23 '25 01:01 yurii-kysel

It would be nice to have this merged. Can someone review it?

psalaberria002 avatar Feb 26 '25 12:02 psalaberria002

@kfcampbell Can we please get this fix merged and released?

awendt avatar Mar 17 '25 14:03 awendt

Hi @kfcampbell can you please review and merge this?

adan-babbel avatar Mar 19 '25 13:03 adan-babbel

@yurii-kysel Should probably also update https://github.com/integrations/terraform-provider-github/blob/main/website/docs/r/organization_ruleset.html.markdown in this PR, too

grimm26 avatar Apr 03 '25 14:04 grimm26

fairly sure this PR fixes https://github.com/integrations/terraform-provider-github/issues/2597 - would be great to have it approved/merged :)

CpuID avatar Apr 28 '25 23:04 CpuID

oh and https://github.com/integrations/terraform-provider-github/issues/2542 would get closed out too (already linked)

CpuID avatar Apr 28 '25 23:04 CpuID

None of that matters unless M$ Github actually allocates time for their people to merge PRs. Plenty of us are actual paying GHE customers and are being ignored.

grimm26 avatar Jul 01 '25 13:07 grimm26