slack
slack copied to clipboard
integrations
Post comments to PRs as Slack Thread replies
It would be neat if the PR integration would create and manage slack threads.
We have a pretty busy repo, with many PRs on going at once - it would be great if each PR could be managed through a thread on slack rather than having to search and filter an entire channel.
This relates to: https://github.com/integrations/slack/issues/660
Thanks for considering!
Thanks for opening this issue! If you would like to help implement an improvement, read more about contributing and consider submitting a pull request.
![welcome[bot] avatar](https://avatars.githubusercontent.com/in/4141?v=4 "Published by a pub.dev verified publisher"){kind=small}
On a similar topic, it would be great if PR reviews (which seem to be considered separately than PR comments) could also be sent to the thread started by the pulls notification "Pull request opened by x" if it exists.
The difficulty of this feature (both for reviews and comments) is finding the original message(s).
Right now it's possible to subscribe to PR notifications (+ comments/reviews) in any slack channel, so the code would require to try to find all the non-threaded messages in each channel the notification should be sent to, if they exist (because it's possible to subscribe to PR notifications/comments even if the original PR message was not sent to Slack).
My suggestion to handle PR reviews and comments in thread (I'm not sure about the feasibility of the search part)
- Change the original PR notification message to include the issue number and the repo name, so we can find it much more easily when searching messages.
GitHubAPP 3:15 PM
Pull request opened by X
+ attachment
Should become
GitHubAPP 3:15 PM
Pull request #{PR_NUMBER} opened in {repo_name} by X
+ attachment
- Before posting a comment/review, search in slack, in each channel the subscription is active, to find a message containing exactly
Pull request #{PR_NUMBER} opened in {repo_name}. Take the last matching message in each channel (by created date), its ID will become the relevant thread_id of the channel.
I'm not sure this type of search is supported/it would require extra permissions
- in each channel the subscription is active, either we have found a thread_id or we have not => either send the message threaded under the message with thread_id or send the notification as a new message
The fact that pull-request has so much slack channel space caused my team to disable it. We are jus pasting the PR link when we want a review. I think it would be good to have it automated. But it neeeds to be more compact.
A thread with details would be a good start.
Emoji updates to original post would also be good.
476 issue-989 SEAL-15000 Udate 3rd party dependencies :changes-requested: :test-ok: :merged:
476 issue-989 SEAL-15000 Udate 3rd party dependencies 👍 💯 🍡
I guess better emojies than my example but you get the point.
This would be a great feature.
In our team we generally post a PR in the engineering channel once a PR is ready for review and we use tags to indicate the status of the PR.
If PR comments were updated in that thread it would greatly improve the general feedback loop.
