slack icon indicating copy to clipboard operation
slack copied to clipboard

Be notified only of PRs where I'm assigned as reviewer

Open JordanGottardoDocplanner opened this issue 2 years ago β€’ 21 comments
trafficstars

Is your feature request related to a problem? Please describe. I don't see a clear way of receiving notifications for only the PRs I am assigned to as a reviewer. I subscribed to a repo using the command /github subscribe <organization>/<repository> pulls . This will notify me whenever a PR is opened. However, I'd like to be notified only when I'm a reviewer of that PR. Since the repository is pretty big, I am being notified for PRs not concerning my work and it's very noisy.

Describe the solution you'd like Be notified only of PRs where I'm a reviewer

Has this been solved?

MM3y3r avatar Feb 17 '23 13:02 MM3y3r

Hello πŸ‘‹ Still not updates? πŸ˜… Especially for monorepos, seems like a standard expected feature

Lp-Francois avatar Apr 13 '23 10:04 Lp-Francois

+1 to this request

VivaLaPanda avatar May 18 '23 15:05 VivaLaPanda

Also +1 on this for monorepos. Otherwise its a noisy mess and defeats the object.

henryhobhouse avatar Jun 14 '23 10:06 henryhobhouse

that would be great to have

yakirSalt avatar Jun 29 '23 17:06 yakirSalt

+1

huseyin-hamilton-cko avatar Aug 03 '23 10:08 huseyin-hamilton-cko

@JordanGottardoDocplanner @huseyin-hamilton-cko @MM3y3r @VivaLaPanda @ashokirla @henryhobhouse @Lp-Francois this can be done via Scheduled Reminders! Check out our bud Rasim's blog post to learn how πŸŽ‰

neighborcaroline avatar Aug 11 '23 18:08 neighborcaroline

https://rasim.pro/blog/personal-slack-github-notifications-for-pull-requests-reviewers-how-to-set-up/

andrii-motorway avatar Jan 08 '24 13:01 andrii-motorway

+1 also for mentions - I cannot use the Scheduled Reminders @neighborcaroline and @andrii-motorway mentioned because the organization doesn't want to set it up.

robertojrdev avatar Apr 08 '24 15:04 robertojrdev

  • 1 really need this

senghorn avatar May 10 '24 15:05 senghorn

This would be super helpful! A large repo results in unnecessary notifications based on repo name only.

ish-joshi avatar May 20 '24 01:05 ish-joshi

Would be really valuable

setvik avatar Jun 13 '24 22:06 setvik

This would be super helpful for me

eric-shiu avatar Jun 14 '24 21:06 eric-shiu

Will be happy for that as well

oriheimlich avatar Jun 16 '24 13:06 oriheimlich

TL;DR "Scheduled Reminders" provides the solution you want

A solution was provided above by @neighborcaroline (and @andrii-motorway) involving "Scheduled Reminders". I initially dismissed that solution as being off-the-mark, since I wasn't looking for daily reminders -- I wanted instant notifications of new events.

However, it ought to be clarified that this solution really will enable immediate notifications, not just daily scheduled reminders. The feature is misnamed. Or rather, misconceptualized. The GitHub/Slack integration ought to be framed as a connector enabling GitHub to send messages to you via Slack. Those messages can be:

  • "A PR was just assigned to you"
  • "Someone commented on your PR"
  • Any of several other events
  • A daily summary of still-open PRs assigned to you

The developers at GitHub, however, conceptualized (and named) the integration specifically as a "Scheduled Reminders" feature, which -- oh, also happens to be able to send "real-time" alerts.

I can't emphasize explicitly and strongly enough that GitHub’s naming the integration "Scheduled Reminders" really masks its true value as an event notification system. The daily reminder aspect of it ought to be downplayed as a nice extra feature, not given the center-stage spotlight.

So... follow the instructions in the blog post. Add your Slack Workspace. Enable the real-time alerts. And, personally, I've disabled the daily Scheduled Reminders by unchecking all 7 days from the list, since (a) it drowned out the real-time alert message history in Slack, and (b) the real-time alerts update themselves with a ~strikethrough~ when the event is no longer relevant, so I can just look at the message history looking for non-~stricken~ alerts.

One last note: When adding the workspace, it showed a scary popup dialog re: migrating from a legacy app to the new one by uninstalling and re-installing, and it had a link to documentation that no longer exists. I was very worried about breaking things for the rest of the company. But it was fine β€” much ado about nothing β€” go ahead and add the workspace.

nmagedman avatar Jun 19 '24 16:06 nmagedman

+1

aleksei-kadeikin avatar Jul 05 '24 12:07 aleksei-kadeikin

+1

victorlee134 avatar Jul 25 '24 15:07 victorlee134

Why is this still an unsolved issue when github and slack are both leaders in their respective product categories?

The primary point of the integration should be to allow developers to quickly notify other reviewers and act on notifications that require their review.

I always end up installing other apps like toast, pullnotifier, etc. (which are all paid at enterprise level btw) to achieve this. The slackbot right now is all unactionable noise.

alankritjoshi avatar Aug 13 '24 03:08 alankritjoshi

+1

zwang1-godaddy avatar Aug 26 '24 22:08 zwang1-godaddy