argocd-commenter icon indicating copy to clipboard operation
argocd-commenter copied to clipboard

Published 20 hours ago • verified publisher icon int128

Support repository and deployment URL of GHES

Open int128 opened this issue 2 years ago • 1 comments

Issue

  • https://github.com/int128/argocd-commenter/issues/865

int128 avatar Feb 18 '23 12:02 int128

Any chance we can get this merged?

I just wrote an identical PR because I missed this one :)

I had to add /api/v3 to the newOAuth2Client BaseURL to get it to work with my instace: https://github.com/Oded-B/argocd-commenter/pull/1/files

The /api/v3 path is automatically added to the "regular" REST calls so the GITHUB_ENTERPRISE_URL doesn't need to include it, maybe it would make more sense to add this logic to https://github.com/int128/oauth2-github-app

Oded-B avatar Jul 26 '23 14:07 Oded-B