instill-core icon indicating copy to clipboard operation
instill-core copied to clipboard

Published 20 hours ago • verified publisher icon instill-ai

[INS-2164] [Feature] Dropdown should open onHover mouse event

Open iamnamananand996 opened this issue 2 years ago • 11 comments
trafficstars

Is There an Existing Issue for This?

  • [X] I have searched the existing issues

Project

Instill Base

Is your Proposal Related to a Problem?

Currently the implementation of dropdown open onClick event, we need add it for onHover also.

CleanShot 2023-09-26 at 01 43 42@2x

Describe Your Proposed Solution

can use mouse event or checkout the https://ui.shadcn.com/docs/components/dropdown-menu, which use to make the dropdown menu component.

Dropdown implementation: https://ui.instill.tech/?path=/docs/components-newui-dropdown--docs

Highlight the Benefits

No response

Anything Else?

No response

INS-2164

iamnamananand996 avatar Sep 27 '23 07:09 iamnamananand996

This issue is a great way to kick-start your journey with our project, or to make a positive impact on open-source development. Jump in!

:sparkles: Thank you for your contribution! :sparkles:

github-actions[bot] avatar Sep 27 '23 07:09 github-actions[bot]

Can i be assigned this ?

AvaterClasher avatar Sep 30 '23 19:09 AvaterClasher

@AvaterClasher Thanks for your will of contributing to our project, we are really appreciated it, please go ahead and file the PR

iamnamananand996 avatar Oct 01 '23 14:10 iamnamananand996

@iamnamananand996 Can you assign me to this?

anurag629 avatar Oct 03 '23 16:10 anurag629

please feel free to assign this to @anurag629

AvaterClasher avatar Oct 03 '23 21:10 AvaterClasher

Hi @anurag629, reassigned on you,

🚀 Here’s the Contributing Guideline for Instill Base to get you started on your journey! Don’t forget to link your pull request to the corresponding issue, and after your PR gets merged, please complete this form to claim your well-deserved points! If you ever have any questions or need a hand along the way, don’t hesitate to drop a message in this thread or hop into our Discord. Happy contributing! 😊🌟

iamnamananand996 avatar Oct 04 '23 09:10 iamnamananand996

Hi @anurag629, reassigned on you,

🚀 Here’s the Contributing Guideline for Instill Base to get you started on your journey! Don’t forget to link your pull request to the corresponding issue, and after your PR gets merged, please complete this form to claim your well-deserved points! If you ever have any questions or need a hand along the way, don’t hesitate to drop a message in this thread or hop into our Discord. Happy contributing! 😊🌟

Thanks, will create a PR soon

anurag629 avatar Oct 04 '23 09:10 anurag629

@iamnamananand996 , I have created a PR. Please take a look at it.

anurag629 avatar Oct 04 '23 16:10 anurag629

Hi @anurag629, thanks for contributing, I checked the PR and added some suggestion, Please have a look.

https://github.com/instill-ai/instill.tech/pull/623#issuecomment-1750467827

iamnamananand996 avatar Oct 09 '23 09:10 iamnamananand996

Hey @iamnamananand996 @harshsoni7 I want to work on this issue. Please assign it to me.

antriksh-9 avatar Oct 24 '23 06:10 antriksh-9

Hi @antriksh-9 reassigned on you,

🚀 Here’s the Contributing Guideline for Instill Base to get you started on your journey! Don’t forget to link your pull request to the corresponding issue, and after your PR gets merged, please complete this form to claim your well-deserved points! If you ever have any questions or need a hand along the way, don’t hesitate to drop a message in this thread or hop into our Discord. Happy contributing! 😊🌟

iamnamananand996 avatar Oct 25 '23 06:10 iamnamananand996