instill-core icon indicating copy to clipboard operation
instill-core copied to clipboard

[INS-2165] [Improvement] While switching between drak/light add splash effect added in the example

Open iamnamananand996 opened this issue 2 years ago • 7 comments
trafficstars

Is There an Existing Issue for This?

  • [X] I have searched the existing issues

Project

Instill Base

Is your Proposal Related to a Problem?

We have the dark mode already build, need to add same kind of splash effect

https://github.com/instill-ai/community/assets/31537362/b54e128b-36c0-4773-869f-fd3881911e57

Describe Your Proposed Improvement

while switching to dark/light mode need to add some css effects

Highlight the Benefits

No response

Anything Else?

No response

INS-2165

iamnamananand996 avatar Sep 27 '23 08:09 iamnamananand996

This issue is a great way to kick-start your journey with our project, or to make a positive impact on open-source development. Jump in!

:sparkles: Thank you for your contribution! :sparkles:

github-actions[bot] avatar Sep 27 '23 08:09 github-actions[bot]

Hey, @iamnamananand996, can you assign this one to me to work on?

ahsanahmad4654 avatar Sep 29 '23 10:09 ahsanahmad4654

Hi there! Absolutely, we’re thrilled about your interest in our project! :rocket: Here’s the Contributing Guideline for Instill Base to get you started on your journey! Don’t forget to link your pull request to the corresponding issue, and after your PR gets merged, please complete this form to claim your well-deserved points! If you ever have any questions or need a hand along the way, don’t hesitate to drop a message in this thread or hop into our Discord. Happy contributing! :blush::star2:

harshsoni7 avatar Oct 04 '23 08:10 harshsoni7

Hi @iamnamananand996, I am a beginner in contributing to open-source projects. Here, I wanted to know what do you mean by adding splash effect? Can you provide some example related to that to be clear so I can contribute to this issue.

prakhar-161 avatar Oct 15 '23 12:10 prakhar-161

@prakhar-161 You can check the app for the current implementation and they had attached the video of what they want. Howeever, i am already working on it and soon will rise the PR.

ahsanahmad4654 avatar Oct 15 '23 17:10 ahsanahmad4654

Thanks for the update @ahsanahmad4654

harshsoni7 avatar Oct 17 '23 11:10 harshsoni7

hello, sorry but I didnt see it was already in progress and I opened a PR, I can close if it is already done!

https://github.com/instill-ai/instill.tech/pull/679

rsmelo92 avatar Jan 03 '24 20:01 rsmelo92