instill-core icon indicating copy to clipboard operation
instill-core copied to clipboard

[Improvement] Pass context instance to avoid breaking the tracing span

Open septemhill opened this issue 1 year ago • 2 comments
trafficstars

Is There an Existing Issue for This?

  • [X] I have searched the existing issues

Where are you aiming to make improvements?

SDK

Is your Proposal Related to a Problem?

I've checked the pipeline-backend repo, there are several function may break the tracing span.

For example:

  • NewACLClient
  • NewConverter
  • RetrievePipelineUsageData

Describe Your Proposed Improvement

Add one more context field in these functions

Highlight the Benefits

No response

Anything Else?

No response

septemhill avatar Sep 03 '24 11:09 septemhill

Hello @septemhill, it's Anni from Instill AI.

Thank you for raising this issue. I have checked this with our engineering team and confirm this improvement can go into our backlog and be improved in the future.

Since the team is busy, if you decide to implement this and raise a PR, please let me know and I can sync with the team.

If you have any questions, please don't hesitate to reach out. Happy building 🙌

kuroxx avatar Sep 05 '24 11:09 kuroxx