jumanji icon indicating copy to clipboard operation
jumanji copied to clipboard

feat: Peg Solitaire env

Open George-Ogden opened this issue 2 years ago • 5 comments

This merge request contains code for a new environment: peg solitaire

George-Ogden avatar Aug 24 '23 19:08 George-Ogden

@George-Ogden What's the status of this PR? Anything I could help with?

carlosgmartin avatar Nov 02 '23 03:11 carlosgmartin

Hi @carlosgmartin Is there a plan to merge this? If so, I can rebase onto main

George-Ogden avatar Nov 02 '23 10:11 George-Ogden

I guess @clement-bonnet or @sash-a needs to approve it?

carlosgmartin avatar Nov 03 '23 00:11 carlosgmartin

I've merged main and fixed the typing, linting and testing issues.

George-Ogden avatar Nov 03 '23 11:11 George-Ogden

Hi @George-Ogden , thank you for the contribution! I think the last discussion led to questions about whether it was best for Solitaire to be integrated into Jumanji or somewhere else given its lack of initial state distribution and stochasticity. We are currently trying to wrap up Pacman, Sokoban, SlidingTilePuzzle, and FlatPack for the camera-ready version of the paper and the 0.4 release. Therefore, we will loop back on Solitaire after the release, and hope to get back to you soon 🙏

clement-bonnet avatar Jan 22 '24 09:01 clement-bonnet