node-deep-equal icon indicating copy to clipboard operation
node-deep-equal copied to clipboard

Published 20 hours ago • verified publisher icon inspect-js

fixed prototype comparison

Open vruivo opened this issue 9 years ago • 6 comments

also added RegExp comparison and some tests

vruivo avatar May 10 '16 00:05 vruivo

@vruivo I found a better alternative here: https://github.com/zubuzon/kewlr. Seems to support this

ghost avatar Oct 07 '16 12:10 ghost

@vruivo if you can resurrect this repository and check the "allow edits" box, we can get this in.

ljharb avatar Jul 31 '19 01:07 ljharb

Added a variant of this RegExp fix, and the tests, in b8c179c5aa91c8a2f71f053e2d9e2d477780250e.

ljharb avatar Jul 31 '19 02:07 ljharb

I believe b8c179c and 43b1eef (and probably a few others) have covered this,

@vruivo if you can check "allow edits" i can update the PR and make sure it's properly merged :-)

ljharb avatar Dec 01 '19 05:12 ljharb

@ljharb looking at this, it does indeed seem to be covered. What is not covered is the possibility of adding additional keys to the regular expression.

const a = /abc/gi
const b = /abc/gi
b.foo = true

deepEqual(a, b)
// Passes even though it should not

BridgeAR avatar Dec 04 '19 01:12 BridgeAR

Resolved in https://github.com/inspect-js/node-deep-equal/commit/1eac46b69c7b499cecb7e3b555b6e260de2043fd

ljharb avatar Dec 05 '19 04:12 ljharb